chia7712 commented on code in PR #15365: URL: https://github.com/apache/kafka/pull/15365#discussion_r1512585166
########## tools/src/test/java/org/apache/kafka/tools/consumer/group/AuthorizerIntegrationTest.java: ########## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.tools.consumer.group; + +import kafka.admin.ConsumerGroupCommand; +import kafka.api.AbstractAuthorizerIntegrationTest; +import kafka.security.authorizer.AclEntry; +import org.apache.kafka.common.acl.AccessControlEntry; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.ValueSource; +import scala.collection.immutable.Map$; + +import java.util.Collections; +import java.util.Properties; + +import static org.apache.kafka.common.acl.AclOperation.DESCRIBE; +import static org.apache.kafka.common.acl.AclPermissionType.ALLOW; +import static org.apache.kafka.tools.ToolsTestUtils.TEST_WITH_PARAMETERIZED_QUORUM_NAME; +import static org.apache.kafka.tools.consumer.group.ConsumerGroupCommandTest.set; + +public class AuthorizerIntegrationTest extends AbstractAuthorizerIntegrationTest { + @ParameterizedTest(name = TEST_WITH_PARAMETERIZED_QUORUM_NAME) + @ValueSource(strings = {"zk", "kraft"}) + public void testDescribeGroupCliWithGroupDescribe(String quorum) { + createTopicWithBrokerPrincipal(topic()); Review Comment: What this case tries to verify is the ACL of "DESCRIBE GROUP". Hence, it does not need to create topic and set the ACL for describing topic. Could you do a bit cleanup for this test case? This is unrelated to this PR but it can decorate this PR :) line#39 and line#41 can be removed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
