chia7712 commented on code in PR #15363: URL: https://github.com/apache/kafka/pull/15363#discussion_r1514366938
########## tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java: ########## @@ -0,0 +1,855 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.tools.consumer.group; + +import kafka.admin.ConsumerGroupCommand; +import org.apache.kafka.clients.consumer.ConsumerConfig; +import org.apache.kafka.clients.consumer.RangeAssignor; +import org.apache.kafka.clients.consumer.RoundRobinAssignor; +import org.apache.kafka.common.TopicPartition; +import org.apache.kafka.common.errors.TimeoutException; +import org.apache.kafka.common.utils.Exit; +import org.apache.kafka.test.TestUtils; +import org.apache.kafka.tools.ToolsTestUtils; +import org.apache.kafka.tools.Tuple2; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.MethodSource; +import org.junit.jupiter.params.provider.ValueSource; +import scala.Function0; +import scala.Function1; +import scala.Option; +import scala.collection.Seq; +import scala.runtime.BoxedUnit; + +import java.util.ArrayList; +import java.util.Arrays; +import java.util.List; +import java.util.Objects; +import java.util.Optional; +import java.util.Properties; +import java.util.concurrent.ExecutionException; +import java.util.concurrent.atomic.AtomicInteger; +import java.util.concurrent.atomic.AtomicReference; + +import static org.apache.kafka.test.TestUtils.DEFAULT_MAX_WAIT_MS; +import static org.apache.kafka.test.TestUtils.RANDOM; +import static org.apache.kafka.tools.ToolsTestUtils.TEST_WITH_PARAMETERIZED_QUORUM_AND_GROUP_PROTOCOL_NAMES; +import static org.apache.kafka.tools.ToolsTestUtils.TEST_WITH_PARAMETERIZED_QUORUM_NAME; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertInstanceOf; +import static org.junit.jupiter.api.Assertions.assertThrows; +import static org.junit.jupiter.api.Assertions.assertTrue; +import static org.junit.jupiter.api.Assertions.fail; + +public class DescribeConsumerGroupTest extends ConsumerGroupCommandTest { + private static final String[][] DESCRIBE_TYPE_OFFSETS = new String[][]{new String[]{""}, new String[]{"--offsets"}}; + private static final String[][] DESCRIBE_TYPE_MEMBERS = new String[][]{new String[]{"--members"}, new String[]{"--members", "--verbose"}}; + private static final String[][] DESCRIBE_TYPE_STATE = new String[][]{new String[]{"--state"}}; + private static final String[][] DESCRIBE_TYPES; + + static { + List<String[]> describeTypes = new ArrayList<>(); + + describeTypes.addAll(Arrays.asList(DESCRIBE_TYPE_OFFSETS)); + describeTypes.addAll(Arrays.asList(DESCRIBE_TYPE_MEMBERS)); + describeTypes.addAll(Arrays.asList(DESCRIBE_TYPE_STATE)); + + DESCRIBE_TYPES = describeTypes.toArray(new String[0][0]); + } + + @ParameterizedTest(name = TEST_WITH_PARAMETERIZED_QUORUM_AND_GROUP_PROTOCOL_NAMES) + @MethodSource({"getTestQuorumAndGroupProtocolParametersAll"}) + public void testDescribeNonExistingGroup(String quorum, String groupProtocol) { + createOffsetsTopic(listenerName(), new Properties()); + String missingGroup = "missing.group"; + + for (String[] describeType : DESCRIBE_TYPES) { + // note the group to be queried is a different (non-existing) group + List<String> cgcArgs = new ArrayList<>(Arrays.asList("--bootstrap-server", bootstrapServers(listenerName()), "--describe", "--group", missingGroup)); + cgcArgs.addAll(Arrays.asList(describeType)); + ConsumerGroupCommand.ConsumerGroupService service = getConsumerGroupService(cgcArgs.toArray(new String[0])); + + String output = kafka.utils.TestUtils.grabConsoleOutput(describeGroups(service)); + assertTrue(output.contains("Consumer group '" + missingGroup + "' does not exist."), + "Expected error was not detected for describe option '" + String.join(" ", describeType) + "'"); + } + } + + @ParameterizedTest(name = TEST_WITH_PARAMETERIZED_QUORUM_NAME) + @ValueSource(strings = {"zk", "kraft"}) + public void testDescribeWithMultipleSubActions(String quorum) { + AtomicInteger exitStatus = new AtomicInteger(0); + AtomicReference<String> exitMessage = new AtomicReference<>(""); + Exit.setExitProcedure((status, err) -> { + exitStatus.set(status); + exitMessage.set(err); + throw new RuntimeException(); + }); + String[] cgcArgs = new String[]{"--bootstrap-server", bootstrapServers(listenerName()), "--describe", "--group", GROUP, "--members", "--state"}; + try { + ConsumerGroupCommand.main(cgcArgs); + } catch (RuntimeException e) { + //expected + } finally { + Exit.resetExitProcedure(); + } + assertEquals(1, exitStatus.get()); + assertTrue(exitMessage.get().contains("Option [describe] takes at most one of these options")); + } + + @ParameterizedTest(name = TEST_WITH_PARAMETERIZED_QUORUM_NAME) + @ValueSource(strings = {"zk", "kraft"}) + public void testDescribeWithStateValue(String quorum) { + AtomicInteger exitStatus = new AtomicInteger(0); + AtomicReference<String> exitMessage = new AtomicReference<>(""); + Exit.setExitProcedure((status, err) -> { + exitStatus.set(status); + exitMessage.set(err); + throw new RuntimeException(); + }); + String[] cgcArgs = new String[]{"--bootstrap-server", bootstrapServers(listenerName()), "--describe", "--all-groups", "--state", "Stable"}; + try { + ConsumerGroupCommand.main(cgcArgs); + } catch (RuntimeException e) { + //expected + } finally { + Exit.resetExitProcedure(); + } + assertEquals(1, exitStatus.get()); + assertTrue(exitMessage.get().contains("Option [describe] does not take a value for [state]")); + } + + @ParameterizedTest(name = TEST_WITH_PARAMETERIZED_QUORUM_AND_GROUP_PROTOCOL_NAMES) + @MethodSource({"getTestQuorumAndGroupProtocolParametersAll"}) + public void testDescribeOffsetsOfNonExistingGroup(String quorum, String groupProtocol) { + String group = "missing.group"; + createOffsetsTopic(listenerName(), new Properties()); + + // run one consumer in the group consuming from a single-partition topic + addConsumerGroupExecutor(1, groupProtocol); + // note the group to be queried is a different (non-existing) group + String[] cgcArgs = new String[]{"--bootstrap-server", bootstrapServers(listenerName()), "--describe", "--group", group}; + ConsumerGroupCommand.ConsumerGroupService service = getConsumerGroupService(cgcArgs); + + scala.Tuple2<Option<String>, Option<Seq<ConsumerGroupCommand.PartitionAssignmentState>>> res = service.collectGroupOffsets(group); + assertTrue(res._1.map(s -> s.contains("Dead")).getOrElse(() -> false) && res._2.map(Seq::isEmpty).getOrElse(() -> false), + "Expected the state to be 'Dead', with no members in the group '" + group + "'."); + } + + @ParameterizedTest(name = TEST_WITH_PARAMETERIZED_QUORUM_AND_GROUP_PROTOCOL_NAMES) + @MethodSource({"getTestQuorumAndGroupProtocolParametersAll"}) + public void testDescribeMembersOfNonExistingGroup(String quorum, String groupProtocol) { + String group = "missing.group"; + createOffsetsTopic(listenerName(), new Properties()); + + // run one consumer in the group consuming from a single-partition topic + addConsumerGroupExecutor(1, groupProtocol); + // note the group to be queried is a different (non-existing) group + String[] cgcArgs = new String[]{"--bootstrap-server", bootstrapServers(listenerName()), "--describe", "--group", group}; + ConsumerGroupCommand.ConsumerGroupService service = getConsumerGroupService(cgcArgs); + + scala.Tuple2<Option<String>, Option<Seq<ConsumerGroupCommand.MemberAssignmentState>>> res = service.collectGroupMembers(group, false); + assertTrue(res._1.map(s -> s.contains("Dead")).getOrElse(() -> false) && res._2.map(Seq::isEmpty).getOrElse(() -> false), + "Expected the state to be 'Dead', with no members in the group '" + group + "'."); + + scala.Tuple2<Option<String>, Option<Seq<ConsumerGroupCommand.MemberAssignmentState>>> res2 = service.collectGroupMembers(group, true); + assertTrue(res2._1.map(s -> s.contains("Dead")).getOrElse(() -> false) && res2._2.map(Seq::isEmpty).getOrElse(() -> false), + "Expected the state to be 'Dead', with no members in the group '" + group + "' (verbose option)."); + } + + @ParameterizedTest(name = TEST_WITH_PARAMETERIZED_QUORUM_AND_GROUP_PROTOCOL_NAMES) + @MethodSource({"getTestQuorumAndGroupProtocolParametersAll"}) + public void testDescribeStateOfNonExistingGroup(String quorum, String groupProtocol) { + String group = "missing.group"; + createOffsetsTopic(listenerName(), new Properties()); + + // run one consumer in the group consuming from a single-partition topic + addConsumerGroupExecutor(1, groupProtocol); + // note the group to be queried is a different (non-existing) group + String[] cgcArgs = new String[]{"--bootstrap-server", bootstrapServers(listenerName()), "--describe", "--group", group}; + ConsumerGroupCommand.ConsumerGroupService service = getConsumerGroupService(cgcArgs); + + ConsumerGroupCommand.GroupState state = service.collectGroupState(group); + assertTrue(Objects.equals(state.state(), "Dead") && state.numMembers() == 0 && + state.coordinator() != null && !brokers().filter(s -> s.config().brokerId() == state.coordinator().id()).isEmpty(), + "Expected the state to be 'Dead', with no members in the group '" + group + "'." + ); + } + + @ParameterizedTest(name = TEST_WITH_PARAMETERIZED_QUORUM_AND_GROUP_PROTOCOL_NAMES) + @MethodSource({"getTestQuorumAndGroupProtocolParametersAll"}) + public void testDescribeExistingGroup(String quorum, String groupProtocol) throws Exception { + createOffsetsTopic(listenerName(), new Properties()); + + for (String[] describeType : DESCRIBE_TYPES) { + String group = GROUP + String.join("", describeType); + // run one consumer in the group consuming from a single-partition topic + addConsumerGroupExecutor(1, TOPIC, group, groupProtocol); + List<String> cgcArgs = new ArrayList<>(Arrays.asList("--bootstrap-server", bootstrapServers(listenerName()), "--describe", "--group", group)); + cgcArgs.addAll(Arrays.asList(describeType)); + ConsumerGroupCommand.ConsumerGroupService service = getConsumerGroupService(cgcArgs.toArray(new String[0])); + + TestUtils.waitForCondition(() -> { + scala.Tuple2<String, String> res = kafka.utils.TestUtils.grabConsoleOutputAndError(describeGroups(service)); + return res._1.trim().split("\n").length == 2 && res._2.isEmpty(); + }, "Expected a data row and no error in describe results with describe type " + String.join(" ", describeType) + "."); + } + } + + @ParameterizedTest(name = TEST_WITH_PARAMETERIZED_QUORUM_AND_GROUP_PROTOCOL_NAMES) + @MethodSource({"getTestQuorumAndGroupProtocolParametersAll"}) + public void testDescribeExistingGroups(String quorum, String groupProtocol) throws Exception { + createOffsetsTopic(listenerName(), new Properties()); + + // Create N single-threaded consumer groups from a single-partition topic + List<String> groups = new ArrayList<>(); + + for (String[] describeType : DESCRIBE_TYPES) { + String group = GROUP + String.join("", describeType); + addConsumerGroupExecutor(1, TOPIC, group, groupProtocol); + groups.addAll(Arrays.asList("--group", group)); + } + + int expectedNumLines = DESCRIBE_TYPES.length * 2; + + for (String[] describeType : DESCRIBE_TYPES) { + List<String> cgcArgs = new ArrayList<>(Arrays.asList("--bootstrap-server", bootstrapServers(listenerName()), "--describe")); + cgcArgs.addAll(groups); + cgcArgs.addAll(Arrays.asList(describeType)); + ConsumerGroupCommand.ConsumerGroupService service = getConsumerGroupService(cgcArgs.toArray(new String[0])); + + TestUtils.waitForCondition(() -> { + scala.Tuple2<String, String> res = kafka.utils.TestUtils.grabConsoleOutputAndError(describeGroups(service)); + long numLines = Arrays.stream(res._1.trim().split("\n")).filter(line -> !line.isEmpty()).count(); + return (numLines == expectedNumLines) && res._2.isEmpty(); + }, "Expected a data row and no error in describe results with describe type " + String.join(" ", describeType) + "."); + } + } + + @ParameterizedTest(name = TEST_WITH_PARAMETERIZED_QUORUM_AND_GROUP_PROTOCOL_NAMES) + @MethodSource({"getTestQuorumAndGroupProtocolParametersAll"}) + public void testDescribeAllExistingGroups(String quorum, String groupProtocol) throws Exception { + createOffsetsTopic(listenerName(), new Properties()); + + // Create N single-threaded consumer groups from a single-partition topic + for (String[] describeType : DESCRIBE_TYPES) { + String group = GROUP + String.join("", describeType); + addConsumerGroupExecutor(1, TOPIC, group, groupProtocol); + } + + int expectedNumLines = DESCRIBE_TYPES.length * 2; + + for (String[] describeType : DESCRIBE_TYPES) { + List<String> cgcArgs = new ArrayList<>(Arrays.asList("--bootstrap-server", bootstrapServers(listenerName()), "--describe", "--all-groups")); + cgcArgs.addAll(Arrays.asList(describeType)); + ConsumerGroupCommand.ConsumerGroupService service = getConsumerGroupService(cgcArgs.toArray(new String[0])); + + TestUtils.waitForCondition(() -> { + scala.Tuple2<String, String> res = kafka.utils.TestUtils.grabConsoleOutputAndError(describeGroups(service)); + long numLines = Arrays.stream(res._1.trim().split("\n")).filter(s -> !s.isEmpty()).count(); + return (numLines == expectedNumLines) && res._2.isEmpty(); + }, "Expected a data row and no error in describe results with describe type " + String.join(" ", describeType) + "."); + } + } + + @ParameterizedTest(name = TEST_WITH_PARAMETERIZED_QUORUM_AND_GROUP_PROTOCOL_NAMES) + @MethodSource({"getTestQuorumAndGroupProtocolParametersAll"}) + public void testDescribeOffsetsOfExistingGroup(String quorum, String groupProtocol) throws Exception { + createOffsetsTopic(listenerName(), new Properties()); + + // run one consumer in the group consuming from a single-partition topic + addConsumerGroupExecutor(1, groupProtocol); + + String[] cgcArgs = new String[]{"--bootstrap-server", bootstrapServers(listenerName()), "--describe", "--group", GROUP}; + ConsumerGroupCommand.ConsumerGroupService service = getConsumerGroupService(cgcArgs); + + TestUtils.waitForCondition(() -> { + scala.Tuple2<Option<String>, Option<Seq<ConsumerGroupCommand.PartitionAssignmentState>>> groupOffsets = service.collectGroupOffsets(GROUP); + Option<String> state = groupOffsets._1; + Option<Seq<ConsumerGroupCommand.PartitionAssignmentState>> assignments = groupOffsets._2; + + Function1<ConsumerGroupCommand.PartitionAssignmentState, Object> isGrp = s -> Objects.equals(s.group(), GROUP); + + boolean res = state.map(s -> s.contains("Stable")).getOrElse(() -> false) && + assignments.isDefined() && + assignments.get().count(isGrp) == 1; + + if (!res) + return false; + + @SuppressWarnings("cast") + ConsumerGroupCommand.PartitionAssignmentState partitionState = + (ConsumerGroupCommand.PartitionAssignmentState) assignments.get().filter(isGrp).head(); + + return !partitionState.consumerId().map(s0 -> s0.trim().equals(ConsumerGroupCommand.MISSING_COLUMN_VALUE())).getOrElse(() -> false) && + !partitionState.clientId().map(s0 -> s0.trim().equals(ConsumerGroupCommand.MISSING_COLUMN_VALUE())).getOrElse(() -> false) && + !partitionState.host().map(h -> h.trim().equals(ConsumerGroupCommand.MISSING_COLUMN_VALUE())).getOrElse(() -> false); + }, "Expected a 'Stable' group status, rows and valid values for consumer id / client id / host columns in describe results for group " + GROUP + "."); + } + + @ParameterizedTest(name = TEST_WITH_PARAMETERIZED_QUORUM_AND_GROUP_PROTOCOL_NAMES) + @MethodSource({"getTestQuorumAndGroupProtocolParametersAll"}) + public void testDescribeMembersOfExistingGroup(String quorum, String groupProtocol) throws Exception { + createOffsetsTopic(listenerName(), new Properties()); + + // run one consumer in the group consuming from a single-partition topic + addConsumerGroupExecutor(1, groupProtocol); + String[] cgcArgs = new String[]{"--bootstrap-server", bootstrapServers(listenerName()), "--describe", "--group", GROUP}; + ConsumerGroupCommand.ConsumerGroupService service = getConsumerGroupService(cgcArgs); + + TestUtils.waitForCondition(() -> { + scala.Tuple2<Option<String>, Option<Seq<ConsumerGroupCommand.MemberAssignmentState>>> groupMembers = service.collectGroupMembers(GROUP, false); + Option<String> state = groupMembers._1; + Option<Seq<ConsumerGroupCommand.MemberAssignmentState>> assignments = groupMembers._2; + + Function1<ConsumerGroupCommand.MemberAssignmentState, Object> isGrp = s -> Objects.equals(s.group(), GROUP); + + boolean res = state.map(s -> s.contains("Stable")).getOrElse(() -> false) && + assignments.isDefined() && + assignments.get().count(s -> Objects.equals(s.group(), GROUP)) == 1; + + if (!res) + return false; + + @SuppressWarnings("cast") + ConsumerGroupCommand.MemberAssignmentState assignmentState = + (ConsumerGroupCommand.MemberAssignmentState) assignments.get().filter(isGrp).head(); + + return !Objects.equals(assignmentState.consumerId(), ConsumerGroupCommand.MISSING_COLUMN_VALUE()) && + !Objects.equals(assignmentState.clientId(), ConsumerGroupCommand.MISSING_COLUMN_VALUE()) && + !Objects.equals(assignmentState.host(), ConsumerGroupCommand.MISSING_COLUMN_VALUE()); + }, "Expected a 'Stable' group status, rows and valid member information for group " + GROUP + "."); + + scala.Tuple2<Option<String>, Option<Seq<ConsumerGroupCommand.MemberAssignmentState>>> res = service.collectGroupMembers(GROUP, true); + + if (res._2.isDefined()) { + assertTrue(res._2.get().size() == 1 && res._2.get().iterator().next().assignment().size() == 1, + "Expected a topic partition assigned to the single group member for group " + GROUP); + } else { + fail("Expected partition assignments for members of group " + GROUP); + } + } + + @ParameterizedTest(name = TEST_WITH_PARAMETERIZED_QUORUM_AND_GROUP_PROTOCOL_NAMES) + @MethodSource({"getTestQuorumAndGroupProtocolParametersAll"}) + public void testDescribeStateOfExistingGroup(String quorum, String groupProtocol) throws Exception { + createOffsetsTopic(listenerName(), new Properties()); + + // run one consumer in the group consuming from a single-partition topic + addConsumerGroupExecutor( + 1, + groupProtocol, + // This is only effective when new protocol is used. + Optional.of("range") + ); + String[] cgcArgs = new String[]{"--bootstrap-server", bootstrapServers(listenerName()), "--describe", "--group", GROUP}; + ConsumerGroupCommand.ConsumerGroupService service = getConsumerGroupService(cgcArgs); + + TestUtils.waitForCondition(() -> { + ConsumerGroupCommand.GroupState state = service.collectGroupState(GROUP); + return Objects.equals(state.state(), "Stable") && + state.numMembers() == 1 && + Objects.equals(state.assignmentStrategy(), "range") && + state.coordinator() != null && + brokers().count(s -> s.config().brokerId() == state.coordinator().id()) > 0; + }, "Expected a 'Stable' group status, with one member and round robin assignment strategy for group " + GROUP + "."); + } + + @ParameterizedTest(name = TEST_WITH_PARAMETERIZED_QUORUM_AND_GROUP_PROTOCOL_NAMES) + @MethodSource({"getTestQuorumAndGroupProtocolParametersAll"}) + public void testDescribeStateOfExistingGroupWithNonDefaultAssignor(String quorum, String groupProtocol) throws Exception { + createOffsetsTopic(listenerName(), new Properties()); + + // run one consumer in the group consuming from a single-partition topic + String expectedName; + if (groupProtocol.equals("consumer")) { + addConsumerGroupExecutor(1, groupProtocol, Optional.of("range")); + expectedName = "range"; + } else { + addConsumerGroupExecutor(1, TOPIC, GROUP, RoundRobinAssignor.class.getName(), Optional.empty(), Optional.empty(), false, groupProtocol); + expectedName = "roundrobin"; + } + String[] cgcArgs = new String[]{"--bootstrap-server", bootstrapServers(listenerName()), "--describe", "--group", GROUP}; + ConsumerGroupCommand.ConsumerGroupService service = getConsumerGroupService(cgcArgs); + + TestUtils.waitForCondition(() -> { + ConsumerGroupCommand.GroupState state = service.collectGroupState(GROUP); + return Objects.equals(state.state(), "Stable") && + state.numMembers() == 1 && + Objects.equals(state.assignmentStrategy(), expectedName) && + state.coordinator() != null && + brokers().count(s -> s.config().brokerId() == state.coordinator().id()) > 0; + }, "Expected a 'Stable' group status, with one member and " + expectedName + " assignment strategy for group " + GROUP + "."); + } + + @ParameterizedTest(name = TEST_WITH_PARAMETERIZED_QUORUM_AND_GROUP_PROTOCOL_NAMES) + @MethodSource({"getTestQuorumAndGroupProtocolParametersAll"}) + public void testDescribeExistingGroupWithNoMembers(String quorum, String groupProtocol) throws Exception { + createOffsetsTopic(listenerName(), new Properties()); + + for (String[] describeType : DESCRIBE_TYPES) { + String group = GROUP + String.join("", describeType); + // run one consumer in the group consuming from a single-partition topic + ConsumerGroupExecutor executor = addConsumerGroupExecutor(1, TOPIC, group, groupProtocol); + List<String> cgcArgs = new ArrayList<>(Arrays.asList("--bootstrap-server", bootstrapServers(listenerName()), "--describe", "--group", group)); + cgcArgs.addAll(Arrays.asList(describeType)); + ConsumerGroupCommand.ConsumerGroupService service = getConsumerGroupService(cgcArgs.toArray(new String[0])); + + TestUtils.waitForCondition(() -> { + scala.Tuple2<String, String> res = kafka.utils.TestUtils.grabConsoleOutputAndError(describeGroups(service)); + return res._1.trim().split("\n").length == 2 && res._2.isEmpty(); + }, "Expected describe group results with one data row for describe type '" + String.join(" ", describeType) + "'"); + + // stop the consumer so the group has no active member anymore + executor.shutdown(); + TestUtils.waitForCondition( + () -> kafka.utils.TestUtils.grabConsoleError(describeGroups(service)).contains("Consumer group '" + group + "' has no active members."), + "Expected no active member in describe group results with describe type " + String.join(" ", describeType)); + } + } + + @ParameterizedTest(name = TEST_WITH_PARAMETERIZED_QUORUM_AND_GROUP_PROTOCOL_NAMES) + @MethodSource({"getTestQuorumAndGroupProtocolParametersAll"}) + public void testDescribeOffsetsOfExistingGroupWithNoMembers(String quorum, String groupProtocol) throws Exception { + createOffsetsTopic(listenerName(), new Properties()); + + // run one consumer in the group consuming from a single-partition topic + ConsumerGroupExecutor executor = addConsumerGroupExecutor(1, TOPIC, GROUP, RangeAssignor.class.getName(), Optional.empty(), Optional.empty(), true, groupProtocol); + + String[] cgcArgs = new String[]{"--bootstrap-server", bootstrapServers(listenerName()), "--describe", "--group", GROUP}; + ConsumerGroupCommand.ConsumerGroupService service = getConsumerGroupService(cgcArgs); + + TestUtils.waitForCondition(() -> { + scala.Tuple2<Option<String>, Option<Seq<ConsumerGroupCommand.PartitionAssignmentState>>> res = service.collectGroupOffsets(GROUP); + return res._1.map(s -> s.contains("Stable")).getOrElse(() -> false) + && res._2.map(c -> c.exists(assignment -> Objects.equals(assignment.group(), GROUP) && assignment.offset().isDefined())).getOrElse(() -> false); + }, "Expected the group to initially become stable, and to find group in assignments after initial offset commit."); + + // stop the consumer so the group has no active member anymore + executor.shutdown(); + + Tuple2<scala.Tuple2<Option<String>, Option<Seq<ConsumerGroupCommand.PartitionAssignmentState>>>, Boolean> res = ToolsTestUtils.computeUntilTrue( Review Comment: We can leverage `TestUtils.waitForCondition` here. The developers can print more information manually if they need to dig in something in the future. ```java TestUtils.waitForCondition(() -> { scala.Tuple2<Option<String>, Option<Seq<ConsumerGroupCommand.PartitionAssignmentState>>> offsets = service.collectGroupOffsets(GROUP); Option<String> state = offsets._1; Option<Seq<ConsumerGroupCommand.PartitionAssignmentState>> assignments = offsets._2; @SuppressWarnings("unchecked") Seq<ConsumerGroupCommand.PartitionAssignmentState> testGroupAssignments = assignments.get().filter(a -> Objects.equals(a.group(), GROUP)).toSeq(); ConsumerGroupCommand.PartitionAssignmentState assignment = testGroupAssignments.head(); return state.map(s -> s.contains("Empty")).getOrElse(() -> false) && testGroupAssignments.size() == 1 && assignment.consumerId().map(c -> c.trim().equals(ConsumerGroupCommand.MISSING_COLUMN_VALUE())).getOrElse(() -> false) && // the member should be gone assignment.clientId().map(c -> c.trim().equals(ConsumerGroupCommand.MISSING_COLUMN_VALUE())).getOrElse(() -> false) && assignment.host().map(c -> c.trim().equals(ConsumerGroupCommand.MISSING_COLUMN_VALUE())).getOrElse(() -> false); }, "failed to collect group offsets"); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
