jolshan commented on code in PR #15486:
URL: https://github.com/apache/kafka/pull/15486#discussion_r1523603267
##########
core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala:
##########
@@ -42,14 +42,26 @@ object AddPartitionsToTxnManager {
val VerificationTimeMsMetricName = "VerificationTimeMs"
}
+/**
+ * This is an enum which handles the Partition Response based on the Produce
Request Version and the exact operation
+ * defaultOperation: This is the default workflow which maps to cases
when the Produce Request Version was lower than expected or when exercising the
offset commit request path
Review Comment:
I think we should include this change in the offset commit path. It will
require bumping that request version as well.
> We will bump the ProduceRequest/Response and
TxnOffsetCommitRequest/Response version to indicate the client is using the new
protocol that doesn’t require adding partitions to transactions and will
implicitly do so. The bump will also support new errors ABORTABLE_ERROR
We are just doing 2 bumps for the above comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
