jolshan commented on code in PR #15486:
URL: https://github.com/apache/kafka/pull/15486#discussion_r1523717757
##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##########
@@ -1504,6 +1507,8 @@ public void handleResponse(AbstractResponse response) {
fatalError(error.exception());
} else if (error == Errors.GROUP_AUTHORIZATION_FAILED) {
abortableError(GroupAuthorizationException.forGroupId(key));
+ } else if (error == Errors.ABORTABLE_TRANSACTION_EXCEPTION) {
Review Comment:
The idea of this error is that we are future proofing. In the future if we
want the producer to abort the transaction (say we have a new use case that
requires this behavior) we can rely on this error to do the correct thing for
older clients. (Or clients 3.8 and later in this case :) )
We ran into this issue a lot when picking error codes for kip-890 part 1. If
we had such an error then, we could have used it for the old clients. Instead,
we chosen INVALID_TXN_STATE which has inconsistent behavior across clients.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
