johnnychhsu commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1526591324
##########
core/src/test/scala/unit/kafka/log/LogValidatorTest.scala:
##########
@@ -404,14 +404,8 @@ class LogValidatorTest {
assertEquals(now + 1, validatingResults.maxTimestampMs,
s"Max timestamp should be ${now + 1}")
- val expectedShallowOffsetOfMaxTimestamp = if (magic >=
RecordVersion.V2.value) {
Review Comment:
if it's LOG_APPEND_TIME, it should be the first record. If not, then we
should choose the correct one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
