johnnychhsu commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1527119875
##########
clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java:
##########
@@ -209,7 +209,7 @@ private static FilterResult filterTo(TopicPartition
partition, Iterable<MutableR
partition, batch.lastOffset(),
maxRecordBatchSize, filteredBatchSize);
MemoryRecordsBuilder.RecordsInfo info = builder.info();
-
filterResult.updateRetainedBatchMetadata(info.maxTimestamp,
info.shallowOffsetOfMaxTimestamp,
+
filterResult.updateRetainedBatchMetadata(info.maxTimestamp,
info.recordOffsetOfMaxTimestamp,
Review Comment:
sounds good to me, I am good with this naming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
