raminqaf opened a new pull request, #15601:
URL: https://github.com/apache/kafka/pull/15601

   #### Description
   The introduced changes provide a cleaner definition of the join side in 
KStreamKStreamJoin. Before, this was done by using a Boolean flag, which led to 
returning a raw LeftOrRightValue without generic arguments because the generic 
type arguments depended on the boolean input.
   
   Tests of @gharris1727 from his 
[PR](https://github.com/apache/kafka/pull/15513) have been adopted to check the 
type-sefty of the joins.
   
   #### Summary of testing strategy
   Unit tests have been added for the new _JoinSide_ enum.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to