raminqaf commented on code in PR #15601: URL: https://github.com/apache/kafka/pull/15601#discussion_r1539078322
########## streams/src/main/java/org/apache/kafka/streams/state/internals/LeftOrRightValue.java: ########## Review Comment: Retroperspectivly, we can refactor this class and break it into two subclasses (`LeftJoinValue<LV, Object>` & `RightJoinValue<Object,RV>`) that implement the same interface (`JoinValue<LV,RV>`). We can use the interface in the enum to make the objects. I wanted to avoid significant changes in this PR and move too many classes simultaneously. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
