lucasbru commented on code in PR #15525:
URL: https://github.com/apache/kafka/pull/15525#discussion_r1538863396
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -1141,21 +1141,27 @@ private Map<TopicPartition, Long>
beginningOrEndOffset(Collection<TopicPartition
if (partitions.isEmpty()) {
return Collections.emptyMap();
}
+
Map<TopicPartition, Long> timestampToSearch = partitions
.stream()
.collect(Collectors.toMap(Function.identity(), tp ->
timestamp));
Timer timer = time.timer(timeout);
ListOffsetsEvent listOffsetsEvent = new ListOffsetsEvent(
timestampToSearch,
- false,
timer);
- Map<TopicPartition, OffsetAndTimestamp> offsetAndTimestampMap =
applicationEventHandler.addAndGet(
+
+ // shortcut the request if the timeout is zero.
+ if (timeout.isZero()) {
Review Comment:
Sorry, only noticed this now, but the original consumer seems to send a list
offset request even if the timeout is 0, and you are specifically introducing
code to avoid that. Isn't that going against what Kirk is trying to achieve? cc
@kirktrue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
