chia7712 commented on code in PR #15668: URL: https://github.com/apache/kafka/pull/15668#discussion_r1554626964
########## server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java: ########## @@ -112,7 +113,7 @@ public ClientMetricsManager(ClientMetricsReceiverPlugin receiverPlugin, int clie this.subscriptionMap = new ConcurrentHashMap<>(); this.subscriptionUpdateVersion = new AtomicInteger(0); this.clientInstanceCache = new SynchronizedCache<>(new LRUCache<>(CACHE_MAX_SIZE)); - this.expirationTimer = new SystemTimerReaper("client-metrics-reaper", new SystemTimer("client-metrics")); + this.expirationTimer = new SystemTimerReaper(CLIENT_METRICS_REAPER_THREAD_NAME, new SystemTimer("client-metrics")); Review Comment: Could you add test to check `SystemTimerReaper#close` does close the system timer? The system timer has inner thread also. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org