chia7712 commented on code in PR #15668:
URL: https://github.com/apache/kafka/pull/15668#discussion_r1554997443
##########
server-common/src/test/java/org/apache/kafka/server/util/timer/TimerTest.java:
##########
@@ -77,7 +77,7 @@ public void setup() {
@AfterEach
public void teardown() throws Exception {
timer.close();
- TestUtils.waitForCondition(() -> timer.isExecutorTerminated(), "timer
excutor not terminated");
+ TestUtils.waitForCondition(() -> timer.isTerminated(), "timer executor
not terminated");
Review Comment:
`timer::isTerminated`
##########
server-common/src/test/java/org/apache/kafka/server/util/timer/SystemTimerReaperTest.java:
##########
@@ -59,4 +60,13 @@ public void testReaper() throws Exception {
timer.close();
}
}
+
+ @Test
+ public void testReaperClose() throws Exception {
+ Timer timer = Mockito.mock(Timer.class);
+ SystemTimerReaper timerReaper = new SystemTimerReaper("reaper", timer);
+ timerReaper.close();
+ Mockito.verify(timer, Mockito.times(1)).close();
+ TestUtils.waitForCondition(() -> timerReaper.isShutdown(), "reaper not
shutdown");
Review Comment:
`timerReaper::isShutdown`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
