OmniaGM commented on code in PR #15684:
URL: https://github.com/apache/kafka/pull/15684#discussion_r1559054203
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetConfig.java:
##########
@@ -20,16 +20,51 @@
import org.apache.kafka.common.record.CompressionType;
public class OffsetConfig {
Review Comment:
I'll move all props, defaults and docs into `GroupCoordinatorConfig` and
move the constructor for `OffsetConfig` as static class within
`GroupCoordinatorConfig` as `GroupMetadataManager` which mainly cares about
`OffsetConfig` doesn't need the rest of the configs in `GroupCoordinatorConfig`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
