chia7712 commented on code in PR #15684: URL: https://github.com/apache/kafka/pull/15684#discussion_r1559703336
########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetConfig.java: ########## @@ -20,16 +20,51 @@ import org.apache.kafka.common.record.CompressionType; public class OffsetConfig { Review Comment: > then we can change the constructor of GroupCoordinatorConfig to accept KafkaConfig that makes sense to me. A unified way to generate those config class can make consistent behavior. > I moved it to kafka.coordinator.group I assume the package you mentioned is in core module, but I'm ok with your approach since it can avoid rewriting java code back to scala code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org