OmniaGM commented on code in PR #15684:
URL: https://github.com/apache/kafka/pull/15684#discussion_r1561280844
##########
core/src/main/scala/kafka/server/KafkaConfig.scala:
##########
@@ -902,40 +824,40 @@ object KafkaConfig {
.define(ControlledShutdownEnableProp, BOOLEAN,
Defaults.CONTROLLED_SHUTDOWN_ENABLE, MEDIUM, ControlledShutdownEnableDoc)
/** ********* Group coordinator configuration ***********/
- .define(GroupMinSessionTimeoutMsProp, INT,
Defaults.GROUP_MIN_SESSION_TIMEOUT_MS, MEDIUM, GroupMinSessionTimeoutMsDoc)
- .define(GroupMaxSessionTimeoutMsProp, INT,
Defaults.GROUP_MAX_SESSION_TIMEOUT_MS, MEDIUM, GroupMaxSessionTimeoutMsDoc)
- .define(GroupInitialRebalanceDelayMsProp, INT,
Defaults.GROUP_INITIAL_REBALANCE_DELAY_MS, MEDIUM,
GroupInitialRebalanceDelayMsDoc)
- .define(GroupMaxSizeProp, INT, Defaults.GROUP_MAX_SIZE, atLeast(1),
MEDIUM, GroupMaxSizeDoc)
+ .define(GroupCoordinatorConfig.GROUP_MIN_SESSION_TIMEOUT_MS_CONFIG, INT,
GroupCoordinatorConfig.GROUP_MIN_SESSION_TIMEOUT_MS_DEFAULT, MEDIUM,
GroupCoordinatorConfig.GROUP_MIN_SESSION_TIMEOUT_MS_DOC)
+ .define(GroupCoordinatorConfig.GROUP_MAX_SESSION_TIMEOUT_MS_CONFIG, INT,
GroupCoordinatorConfig.GROUP_MAX_SESSION_TIMEOUT_MS_DEFAULT, MEDIUM,
GroupCoordinatorConfig.GROUP_MAX_SESSION_TIMEOUT_MS_DOC)
+ .define(GroupCoordinatorConfig.GROUP_INITIAL_REBALANCE_DELAY_MS_CONFIG,
INT, GroupCoordinatorConfig.GROUP_INITIAL_REBALANCE_DELAY_MS_DEFAULT, MEDIUM,
GroupCoordinatorConfig.GROUP_INITIAL_REBALANCE_DELAY_MS_DOC)
+ .define(GroupCoordinatorConfig.GROUP_MAX_SIZE_CONFIG, INT,
GroupCoordinatorConfig.GROUP_MAX_SIZE_DEFAULT, atLeast(1), MEDIUM,
GroupCoordinatorConfig.GROUP_MAX_SIZE_DOC)
/** New group coordinator configs */
- .define(GroupCoordinatorRebalanceProtocolsProp, LIST,
Defaults.GROUP_COORDINATOR_REBALANCE_PROTOCOLS,
- ConfigDef.ValidList.in(Utils.enumOptions(classOf[GroupType]):_*),
MEDIUM, GroupCoordinatorRebalanceProtocolsDoc)
- .define(GroupCoordinatorNumThreadsProp, INT,
Defaults.GROUP_COORDINATOR_NUM_THREADS, atLeast(1), MEDIUM,
GroupCoordinatorNumThreadsDoc)
+
.define(GroupCoordinatorConfig.GROUP_COORDINATOR_REBALANCE_PROTOCOLS_CONFIG,
LIST, GroupCoordinatorConfig.GROUP_COORDINATOR_REBALANCE_PROTOCOLS_DEFAULT,
+ ConfigDef.ValidList.in(Utils.enumOptions(classOf[GroupType]):_*),
MEDIUM, GroupCoordinatorConfig.GROUP_COORDINATOR_REBALANCE_PROTOCOLS_DOC)
+ .define(GroupCoordinatorConfig.GROUP_COORDINATOR_NUM_THREADS_CONFIG,
INT, GroupCoordinatorConfig.GROUP_COORDINATOR_NUM_THREADS_DEFAULT, atLeast(1),
MEDIUM, GroupCoordinatorConfig.GROUP_COORDINATOR_NUM_THREADS_DOC)
// Internal configuration used by integration and system tests.
- .defineInternal(NewGroupCoordinatorEnableProp, BOOLEAN,
Defaults.NEW_GROUP_COORDINATOR_ENABLE, null, MEDIUM,
NewGroupCoordinatorEnableDoc)
+
.defineInternal(GroupCoordinatorConfig.NEW_GROUP_COORDINATOR_ENABLE_CONFIG,
BOOLEAN, GroupCoordinatorConfig.NEW_GROUP_COORDINATOR_ENABLE_DEFAULT, null,
MEDIUM, GroupCoordinatorConfig.NEW_GROUP_COORDINATOR_ENABLE_DOC)
/** Consumer groups configs */
- .define(ConsumerGroupSessionTimeoutMsProp, INT,
Defaults.CONSUMER_GROUP_SESSION_TIMEOUT_MS, atLeast(1), MEDIUM,
ConsumerGroupSessionTimeoutMsDoc)
- .define(ConsumerGroupMinSessionTimeoutMsProp, INT,
Defaults.CONSUMER_GROUP_MIN_SESSION_TIMEOUT_MS, atLeast(1), MEDIUM,
ConsumerGroupMinSessionTimeoutMsDoc)
- .define(ConsumerGroupMaxSessionTimeoutMsProp, INT,
Defaults.CONSUMER_GROUP_MAX_SESSION_TIMEOUT_MS, atLeast(1), MEDIUM,
ConsumerGroupMaxSessionTimeoutMsDoc)
- .define(ConsumerGroupHeartbeatIntervalMsProp, INT,
Defaults.CONSUMER_GROUP_HEARTBEAT_INTERVAL_MS, atLeast(1), MEDIUM,
ConsumerGroupHeartbeatIntervalMsDoc)
- .define(ConsumerGroupMinHeartbeatIntervalMsProp, INT,
Defaults.CONSUMER_GROUP_MIN_HEARTBEAT_INTERVAL_MS, atLeast(1), MEDIUM,
ConsumerGroupMinHeartbeatIntervalMsDoc)
- .define(ConsumerGroupMaxHeartbeatIntervalMsProp, INT,
Defaults.CONSUMER_GROUP_MAX_HEARTBEAT_INTERVAL_MS, atLeast(1), MEDIUM,
ConsumerGroupMaxHeartbeatIntervalMsDoc)
- .define(ConsumerGroupMaxSizeProp, INT, Defaults.CONSUMER_GROUP_MAX_SIZE,
atLeast(1), MEDIUM, ConsumerGroupMaxSizeDoc)
- .define(ConsumerGroupAssignorsProp, LIST,
Defaults.CONSUMER_GROUP_ASSIGNORS, null, MEDIUM, ConsumerGroupAssignorsDoc)
- .defineInternal(ConsumerGroupMigrationPolicyProp, STRING,
Defaults.CONSUMER_GROUP_MIGRATION_POLICY,
ConfigDef.CaseInsensitiveValidString.in(Utils.enumOptions(classOf[ConsumerGroupMigrationPolicy]):
_*), MEDIUM, ConsumerGroupMigrationPolicyDoc)
+ .define(GroupCoordinatorConfig.CONSUMER_GROUP_SESSION_TIMEOUT_MS_CONFIG,
INT, GroupCoordinatorConfig.CONSUMER_GROUP_SESSION_TIMEOUT_MS_DEFAULT,
atLeast(1), MEDIUM,
GroupCoordinatorConfig.CONSUMER_GROUP_SESSION_TIMEOUT_MS_DOC)
+
.define(GroupCoordinatorConfig.CONSUMER_GROUP_MIN_SESSION_TIMEOUT_MS_CONFIG,
INT, GroupCoordinatorConfig.CONSUMER_GROUP_MIN_SESSION_TIMEOUT_MS_DEFAULT,
atLeast(1), MEDIUM,
GroupCoordinatorConfig.CONSUMER_GROUP_MIN_SESSION_TIMEOUT_MS_DOC)
+
.define(GroupCoordinatorConfig.CONSUMER_GROUP_MAX_SESSION_TIMEOUT_MS_CONFIG,
INT, GroupCoordinatorConfig.CONSUMER_GROUP_MAX_SESSION_TIMEOUT_MS_DEFAULT,
atLeast(1), MEDIUM,
GroupCoordinatorConfig.CONSUMER_GROUP_MAX_SESSION_TIMEOUT_MS_DOC)
+
.define(GroupCoordinatorConfig.CONSUMER_GROUP_HEARTBEAT_INTERVAL_MS_CONFIG,
INT, GroupCoordinatorConfig.CONSUMER_GROUP_HEARTBEAT_INTERVAL_MS_DEFAULT,
atLeast(1), MEDIUM,
GroupCoordinatorConfig.CONSUMER_GROUP_HEARTBEAT_INTERVAL_MS_DOC)
+
.define(GroupCoordinatorConfig.CONSUMER_GROUP_MIN_HEARTBEAT_INTERVAL_MS_CONFIG,
INT, GroupCoordinatorConfig.CONSUMER_GROUP_MIN_HEARTBEAT_INTERVAL_MS_DEFAULT,
atLeast(1), MEDIUM,
GroupCoordinatorConfig.CONSUMER_GROUP_MIN_HEARTBEAT_INTERVAL_MS_DOC)
+
.define(GroupCoordinatorConfig.CONSUMER_GROUP_MAX_HEARTBEAT_INTERVAL_MS_CONFIG,
INT, GroupCoordinatorConfig.CONSUMER_GROUP_MAX_HEARTBEAT_INTERVAL_MS_DEFAULT,
atLeast(1), MEDIUM,
GroupCoordinatorConfig.CONSUMER_GROUP_MAX_HEARTBEAT_INTERVAL_MS_DOC)
+ .define(GroupCoordinatorConfig.CONSUMER_GROUP_MAX_SIZE_CONFIG, INT,
GroupCoordinatorConfig.CONSUMER_GROUP_MAX_SIZE_DEFAULT, atLeast(1), MEDIUM,
GroupCoordinatorConfig.CONSUMER_GROUP_MAX_SIZE_DOC)
+ .define(GroupCoordinatorConfig.CONSUMER_GROUP_ASSIGNORS_CONFIG, LIST,
GroupCoordinatorConfig.CONSUMER_GROUP_ASSIGNORS_DEFAULT, null, MEDIUM,
GroupCoordinatorConfig.CONSUMER_GROUP_ASSIGNORS_DOC)
+
.defineInternal(GroupCoordinatorConfig.CONSUMER_GROUP_MIGRATION_POLICY_CONFIG,
STRING, GroupCoordinatorConfig.CONSUMER_GROUP_MIGRATION_POLICY_DEFAULT,
ConfigDef.CaseInsensitiveValidString.in(Utils.enumOptions(classOf[ConsumerGroupMigrationPolicy]):
_*), MEDIUM, GroupCoordinatorConfig.CONSUMER_GROUP_MIGRATION_POLICY_DOC)
/** ********* Offset management configuration ***********/
- .define(OffsetMetadataMaxSizeProp, INT,
Defaults.OFFSET_METADATA_MAX_SIZE, HIGH, OffsetMetadataMaxSizeDoc)
- .define(OffsetsLoadBufferSizeProp, INT,
Defaults.OFFSETS_LOAD_BUFFER_SIZE, atLeast(1), HIGH, OffsetsLoadBufferSizeDoc)
- .define(OffsetsTopicReplicationFactorProp, SHORT,
Defaults.OFFSETS_TOPIC_REPLICATION_FACTOR, atLeast(1), HIGH,
OffsetsTopicReplicationFactorDoc)
- .define(OffsetsTopicPartitionsProp, INT,
Defaults.OFFSETS_TOPIC_PARTITIONS, atLeast(1), HIGH, OffsetsTopicPartitionsDoc)
- .define(OffsetsTopicSegmentBytesProp, INT,
Defaults.OFFSETS_TOPIC_SEGMENT_BYTES, atLeast(1), HIGH,
OffsetsTopicSegmentBytesDoc)
- .define(OffsetsTopicCompressionCodecProp, INT,
Defaults.OFFSETS_TOPIC_COMPRESSION_CODEC, HIGH, OffsetsTopicCompressionCodecDoc)
- .define(OffsetsRetentionMinutesProp, INT,
Defaults.OFFSETS_RETENTION_MINUTES, atLeast(1), HIGH,
OffsetsRetentionMinutesDoc)
- .define(OffsetsRetentionCheckIntervalMsProp, LONG,
Defaults.OFFSETS_RETENTION_CHECK_INTERVAL_MS, atLeast(1), HIGH,
OffsetsRetentionCheckIntervalMsDoc)
- .define(OffsetCommitTimeoutMsProp, INT,
Defaults.OFFSET_COMMIT_TIMEOUT_MS, atLeast(1), HIGH, OffsetCommitTimeoutMsDoc)
- .define(OffsetCommitRequiredAcksProp, SHORT,
Defaults.OFFSET_COMMIT_REQUIRED_ACKS, HIGH, OffsetCommitRequiredAcksDoc)
+ .define(GroupCoordinatorConfig.OFFSET_METADATA_MAX_SIZE_CONFIG, INT,
GroupCoordinatorConfig.OFFSET_METADATA_MAX_SIZE_DEFAULT, HIGH,
GroupCoordinatorConfig.OFFSET_METADATA_MAX_SIZE_DOC)
+ .define(GroupCoordinatorConfig.OFFSETS_LOAD_BUFFER_SIZE_CONFIG, INT,
GroupCoordinatorConfig.OFFSETS_LOAD_BUFFER_SIZE_DEFAULT, atLeast(1), HIGH,
GroupCoordinatorConfig.OFFSETS_LOAD_BUFFER_SIZE_DOC)
+ .define(GroupCoordinatorConfig.OFFSETS_TOPIC_REPLICATION_FACTOR_CONFIG,
SHORT, GroupCoordinatorConfig.OFFSETS_TOPIC_REPLICATION_FACTOR_DEFAULT,
atLeast(1), HIGH, GroupCoordinatorConfig.OFFSETS_TOPIC_REPLICATION_FACTOR_DOC)
+ .define(GroupCoordinatorConfig.OFFSETS_TOPIC_PARTITIONS_CONFIG, INT,
GroupCoordinatorConfig.OFFSETS_TOPIC_PARTITIONS_DEFAULT, atLeast(1), HIGH,
GroupCoordinatorConfig.OFFSETS_TOPIC_PARTITIONS_DOC)
+ .define(GroupCoordinatorConfig.OFFSETS_TOPIC_SEGMENT_BYTES_CONFIG, INT,
GroupCoordinatorConfig.OFFSETS_TOPIC_SEGMENT_BYTES_DEFAULT, atLeast(1), HIGH,
GroupCoordinatorConfig.OFFSETS_TOPIC_SEGMENT_BYTES_DOC)
+ .define(GroupCoordinatorConfig.OFFSETS_TOPIC_COMPRESSION_CODEC_CONFIG,
INT, GroupCoordinatorConfig.OFFSETS_TOPIC_COMPRESSION_CODEC_DEFAULT, HIGH,
GroupCoordinatorConfig.OFFSETS_TOPIC_COMPRESSION_CODEC_DOC)
Review Comment:
good spot. Fixed now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
