chia7712 commented on code in PR #15136:
URL: https://github.com/apache/kafka/pull/15136#discussion_r1565571409
##########
core/src/test/java/kafka/testkit/BrokerNode.java:
##########
@@ -81,8 +82,7 @@ public BrokerNode build(
logDataDirectories = Collections.
singletonList(String.format("combined_%d", id));
} else {
- logDataDirectories = Collections.
- singletonList(String.format("broker_%d_data0", id));
+ logDataDirectories =
Collections.unmodifiableList(Arrays.asList(String.format("broker_%d_data0",
id), String.format("broker_%d_data1", id)));
Review Comment:
Personally, I'd like to change setNumBrokerNodes(int) to setBrokerNodes(int,
int). The second argument is used to define the number of data folders. After
all, not all tests require 2+ folders. Maybe we can address that in another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
