showuon commented on code in PR #15744:
URL: https://github.com/apache/kafka/pull/15744#discussion_r1577340553


##########
core/src/test/scala/unit/kafka/zk/AdminZkClientTest.scala:
##########
@@ -194,6 +199,8 @@ class AdminZkClientTest extends QuorumTestHarness with 
Logging with RackAwareTes
    */
   @Test
   def testTopicConfigChange(): Unit = {
+    TestUtils.deleteControllerFromZk(zkClient)

Review Comment:
   I can understand we need to createController in ZK first to set configs. But 
I don't understand why we should delete the controller from ZK here? Might need 
some comments for it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to