johnnychhsu commented on PR #15788: URL: https://github.com/apache/kafka/pull/15788#issuecomment-2077461634
> @johnnychhsu Instead of removing them, could you make `MetadataLogConfig` use those help methods? > The reason these aren't used is because `MetadataLogConfig` signature uses `AbstractConfig` and not `KafkaConfig`. We should update `MetadataLogConfig` class and make it use these methods as @chia7712 mentioned. @chia7712 @OmniaGM just updated according to the suggestions, thanks for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
