chia7712 commented on code in PR #15788:
URL: https://github.com/apache/kafka/pull/15788#discussion_r1582265983
##########
core/src/main/scala/kafka/MetadataLogConfig.scala:
##########
@@ -32,13 +32,13 @@ final case class MetadataLogConfig(
)
object MetadataLogConfig {
- def apply(config: AbstractConfig, maxBatchSizeInBytes: Int,
maxFetchSizeInBytes: Int): MetadataLogConfig = {
+ def apply(config: KafkaConfig, maxBatchSizeInBytes: Int,
maxFetchSizeInBytes: Int): MetadataLogConfig = {
new MetadataLogConfig(
- config.getInt(KRaftConfigs.METADATA_LOG_SEGMENT_BYTES_CONFIG),
- config.getInt(KRaftConfigs.METADATA_LOG_SEGMENT_MIN_BYTES_CONFIG),
- config.getLong(KRaftConfigs.METADATA_LOG_SEGMENT_MILLIS_CONFIG),
- config.getLong(KRaftConfigs.METADATA_MAX_RETENTION_BYTES_CONFIG),
- config.getLong(KRaftConfigs.METADATA_MAX_RETENTION_MILLIS_CONFIG),
+ config.metadataLogSegmentBytes,
+ config.metadataLogSegmentMinBytes,
+ config.metadataLogSegmentMillis,
+ config.metadataRetentionBytes,
+ config.metadataRetentionMillis,
maxBatchSizeInBytes,
maxFetchSizeInBytes,
ServerLogConfigs.LOG_DELETE_DELAY_MS_DEFAULT,
Review Comment:
Could you change line#45 to use `config.nodeId`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
