OmniaGM commented on code in PR #15822:
URL: https://github.com/apache/kafka/pull/15822#discussion_r1582144106
##########
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java:
##########
@@ -77,7 +78,7 @@ public class CommonClientConfigs {
public static final String CLIENT_RACK_CONFIG = "client.rack";
public static final String CLIENT_RACK_DOC = "A rack identifier for this
client. This can be any string value which indicates where this client is
physically located. It corresponds with the broker config 'broker.rack'";
- public static final String DEFAULT_CLIENT_RACK = "";
+ public static final String CLIENT_RACK_DEFAULT = "";
Review Comment:
had a second thought about this and instead of raising a KIP I decided to
just move all metric configs in one place for now in `MetricConfigs`. As I want
to keep KAFKA-15853 as simple as possible as it already huge effort to move
these config out of core. I will create a cleanup Jiras to align the naming
convention for some of these config files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
