OmniaGM commented on code in PR #15822:
URL: https://github.com/apache/kafka/pull/15822#discussion_r1582152852


##########
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java:
##########
@@ -77,7 +78,7 @@ public class CommonClientConfigs {
 
     public static final String CLIENT_RACK_CONFIG = "client.rack";
     public static final String CLIENT_RACK_DOC = "A rack identifier for this 
client. This can be any string value which indicates where this client is 
physically located. It corresponds with the broker config 'broker.rack'";
-    public static final String DEFAULT_CLIENT_RACK = "";
+    public static final String CLIENT_RACK_DEFAULT = "";

Review Comment:
   Created this jira https://issues.apache.org/jira/browse/KAFKA-16638 as a 
followup to align the naming convention for config classes. Left note there 
that some classes need KIPs and might need a separate jira later. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to