lianetm commented on code in PR #15843:
URL: https://github.com/apache/kafka/pull/15843#discussion_r1587645917
##########
core/src/test/scala/integration/kafka/api/PlaintextConsumerCommitTest.scala:
##########
@@ -271,6 +272,19 @@ class PlaintextConsumerCommitTest extends
AbstractConsumerTest {
consumer.commitSync()
}
+ @ParameterizedTest(name =
TestInfoUtils.TestWithParameterizedQuorumAndGroupProtocolNames)
+ @MethodSource(Array("getTestQuorumAndGroupProtocolParametersAll"))
+ @Timeout(15)
+ def testPositionRespectsTimeout(quorum: String, groupProtocol: String): Unit
= {
Review Comment:
This test covers a position API behaviour that is unrelated to the committed
offsets as I see it (we expect exactly the same when retrieving positions based
on the partitions offsets from the leader instead of the committed offsets from
the coordinator), so I would say it shouldn't be in this file ? Since there is
not specific file for positions-related tests I would suggest we move it to the
generic `PlainTextConsumerTest`. Makes sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
