kirktrue commented on code in PR #15843:
URL: https://github.com/apache/kafka/pull/15843#discussion_r1588224603
##########
core/src/test/scala/integration/kafka/api/PlaintextConsumerCommitTest.scala:
##########
@@ -271,6 +272,19 @@ class PlaintextConsumerCommitTest extends
AbstractConsumerTest {
consumer.commitSync()
}
+ @ParameterizedTest(name =
TestInfoUtils.TestWithParameterizedQuorumAndGroupProtocolNames)
+ @MethodSource(Array("getTestQuorumAndGroupProtocolParametersAll"))
+ @Timeout(15)
+ def testPositionRespectsTimeout(quorum: String, groupProtocol: String): Unit
= {
Review Comment:
> Since there is not specific file for positions-related tests I would
suggest we move it to the generic `PlainTextConsumerTest`. Makes sense?
I agree. Before I stuck it there, I looked around for any other tests named
`test*Position*`. The only test I saw was `testPositionAndCommit` in
`PlaintextConsumerCommitTest`, so 🤷♂️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
