chia7712 commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1590222768
##########
tools/src/main/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommand.java:
##########
@@ -430,7 +430,7 @@ private void printStates(Map<String, GroupState> states) {
String format = "\n%" + -coordinatorColLen + "s %-25s
%-20s %-15s %s";
System.out.printf(format, "GROUP", "COORDINATOR (ID)",
"ASSIGNMENT-STRATEGY", "STATE", "#MEMBERS");
- System.out.printf(format, state.group, coordinator,
state.assignmentStrategy, state.state, state.numMembers);
+ System.out.printf(format, state.group, coordinator,
state.assignmentStrategy, state.state.name(), state.numMembers);
Review Comment:
Sorry that we should use `toString()` instead of `name()`
##########
core/src/test/java/kafka/test/ClusterInstance.java:
##########
@@ -145,4 +153,18 @@ default Admin createAdminClient() {
void startBroker(int brokerId);
void waitForReadyBrokers() throws InterruptedException;
+
+ default Set<GroupProtocol> supportedGroupProtocols() {
Review Comment:
Could you please add test for it? `ClusterTestExtensionsTest` is a goo place
:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
