johnnychhsu commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1592759299
##########
core/src/test/java/kafka/test/ClusterConfig.java:
##########
@@ -153,15 +148,19 @@ public Map<Integer, Map<String, String>>
perBrokerOverrideProperties() {
return perBrokerOverrideProperties;
}
- public Map<String, String> nameTags() {
- Map<String, String> tags = new LinkedHashMap<>(4);
- name().ifPresent(name -> tags.put("Name", name));
- tags.put("MetadataVersion", metadataVersion.toString());
- tags.put("Security", securityProtocol.name());
- listenerName().ifPresent(listener -> tags.put("Listener", listener));
+ public String[] tags() {
return tags;
}
+ public Map<String, String> nameTags() {
Review Comment:
since we can get the tags from the getter, why do we still need to add this
into the displayTags?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
