johnnychhsu commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1597412007
##########
core/src/test/java/kafka/test/ClusterConfig.java:
##########
@@ -83,6 +83,7 @@ private ClusterConfig(Type type, int brokers, int
controllers, int disksPerBroke
this.saslServerProperties =
Objects.requireNonNull(saslServerProperties);
this.saslClientProperties =
Objects.requireNonNull(saslClientProperties);
this.perBrokerOverrideProperties =
Objects.requireNonNull(perBrokerOverrideProperties);
+ this.tags = tags;
Review Comment:
originally I use `Objects.requireNonNull(tags);` but I was not sure if we
should make this required since users might not need this, so basically we
want/expect users to provide for the display purpose, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
