chia7712 commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1597465579
##########
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommandTestUtils.java:
##########
@@ -55,19 +56,22 @@ static void generator(ClusterGenerator clusterGenerator) {
ClusterConfig zk = ClusterConfig.defaultBuilder()
.setType(ZK)
+ .setTags(Collections.singletonList("newGroupCoordinator"))
.setServerProperties(serverProperties)
.build();
clusterGenerator.accept(zk);
ClusterConfig raftWithLegacyCoordinator =
ClusterConfig.defaultBuilder()
.setType(KRAFT)
+ .setTags(Collections.singletonList("newGroupCoordinator"))
.setServerProperties(serverProperties)
.build();
clusterGenerator.accept(raftWithLegacyCoordinator);
ClusterConfig combinedKRaftWithLegacyCoordinator =
ClusterConfig.defaultBuilder()
.setType(CO_KRAFT)
.setServerProperties(serverProperties)
+ .setTags(Collections.singletonList("newGroupCoordinator"))
Review Comment:
ditto
##########
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommandTestUtils.java:
##########
@@ -55,19 +56,22 @@ static void generator(ClusterGenerator clusterGenerator) {
ClusterConfig zk = ClusterConfig.defaultBuilder()
.setType(ZK)
+ .setTags(Collections.singletonList("newGroupCoordinator"))
.setServerProperties(serverProperties)
.build();
clusterGenerator.accept(zk);
ClusterConfig raftWithLegacyCoordinator =
ClusterConfig.defaultBuilder()
.setType(KRAFT)
+ .setTags(Collections.singletonList("newGroupCoordinator"))
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
