cmccabe commented on code in PR #15876:
URL: https://github.com/apache/kafka/pull/15876#discussion_r1599218098
##########
clients/src/main/java/org/apache/kafka/common/requests/ElectLeadersRequest.java:
##########
@@ -75,6 +76,13 @@ private ElectLeadersRequestData toRequestData(short version)
{
data.topicPartitions().add(tps);
}
tps.partitions().add(tp.partition());
+ if (version >= 3) {
Review Comment:
Honestly I find it annoying that this class does this kind of "manual
serialization" rather than simply using the generated KRPC classes. Anyway, if
we start using a subclass of TopicPartition, then this will change.
##########
clients/src/main/java/org/apache/kafka/common/requests/ElectLeadersRequest.java:
##########
@@ -75,6 +76,13 @@ private ElectLeadersRequestData toRequestData(short version)
{
data.topicPartitions().add(tps);
}
tps.partitions().add(tp.partition());
+ if (version >= 3) {
Review Comment:
Honestly I find it annoying that this class does this kind of "manual
serialization" rather than simply using the generated KRPC classes. Anyway, if
we start using a subclass of TopicPartition, then this will change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
