cmccabe commented on code in PR #15876:
URL: https://github.com/apache/kafka/pull/15876#discussion_r1599220577
##########
core/src/main/scala/kafka/controller/KafkaController.scala:
##########
@@ -920,6 +920,7 @@ class KafkaController(val config: KafkaConfig,
* triggered by the admin client
*/
OfflinePartitionLeaderElectionStrategy(allowUnclean =
electionTrigger == AdminClientTriggered)
+ case ElectionType.DESIGNATED => throw new RuntimeException("Designated
election not supported by KafkaController")
Review Comment:
Something like "in ZK mode" would be more helpful. Also, what is the error
passed back to the user?
Why is this not UnsupportedVersionException rather than a generic runtime
error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
