kirktrue commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1599232056
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##########
@@ -144,6 +150,36 @@ void runOnce() {
.map(Optional::get)
.map(rm -> rm.maximumTimeToWait(currentTimeMs))
.reduce(Long.MAX_VALUE, Math::min);
+
+ reapExpiredApplicationEvents(currentTimeMs);
+ }
+
+ /**
+ * Process the events—if any—that were produced by the application thread.
+ */
+ private void processApplicationEvents() {
+ LinkedList<ApplicationEvent> events = new LinkedList<>();
+ applicationEventQueue.drainTo(events);
+
+ for (ApplicationEvent event : events) {
+ try {
+ if (event instanceof CompletableApplicationEvent)
+
applicationEventReaper.add((CompletableApplicationEvent<?>) event);
+
+ applicationEventProcessor.process(event);
+ } catch (Throwable t) {
+ log.warn("Error processing event {}", t.getMessage(), t);
Review Comment:
There's some debate over that, for sure. However, this is the same error
processing we've used before this change, so hopefully we can continue that
debate separately?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
