kirktrue commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1599232355
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CompletableApplicationEvent.java:
##########
@@ -32,13 +29,9 @@ public abstract class CompletableApplicationEvent<T> extends
ApplicationEvent im
private final CompletableFuture<T> future;
private final long deadlineMs;
- protected CompletableApplicationEvent(final Type type, final Timer timer) {
- super(type);
- this.future = new CompletableFuture<>();
- Objects.requireNonNull(timer);
- this.deadlineMs = timer.remainingMs() + timer.currentTimeMs();
- }
-
+ /**
+ * <em>Note</em>: the {@code deadlineMs} is the future time of expiration,
<em>not</em> a timeout.
+ */
Review Comment:
We've had some confusion in the past between timeouts and expiration, but I
can remove it if you firmly want it removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
