mimaison commented on code in PR #15516:
URL: https://github.com/apache/kafka/pull/15516#discussion_r1603325731
##########
server-common/src/test/java/org/apache/kafka/server/record/BrokerCompressionTypeTest.java:
##########
@@ -16,23 +16,38 @@
*/
package org.apache.kafka.server.record;
+import org.apache.kafka.common.compress.Compression;
+import org.apache.kafka.common.compress.GzipCompression;
+import org.apache.kafka.common.compress.Lz4Compression;
+import org.apache.kafka.common.compress.SnappyCompression;
+import org.apache.kafka.common.compress.ZstdCompression;
import org.apache.kafka.common.record.CompressionType;
import org.junit.jupiter.api.Test;
+import java.util.Optional;
+
import static org.junit.jupiter.api.Assertions.assertEquals;
public class BrokerCompressionTypeTest {
@Test
public void testTargetCompressionType() {
- assertEquals(CompressionType.GZIP,
BrokerCompressionType.GZIP.targetCompressionType(CompressionType.ZSTD));
- assertEquals(CompressionType.SNAPPY,
BrokerCompressionType.SNAPPY.targetCompressionType(CompressionType.LZ4));
- assertEquals(CompressionType.LZ4,
BrokerCompressionType.LZ4.targetCompressionType(CompressionType.ZSTD));
- assertEquals(CompressionType.ZSTD,
BrokerCompressionType.ZSTD.targetCompressionType(CompressionType.GZIP));
-
- assertEquals(CompressionType.LZ4,
BrokerCompressionType.PRODUCER.targetCompressionType(CompressionType.LZ4));
- assertEquals(CompressionType.ZSTD,
BrokerCompressionType.PRODUCER.targetCompressionType(CompressionType.ZSTD));
+ GzipCompression gzipWithLevel =
Compression.gzip().level(GzipCompression.MAX_LEVEL).build();
+ assertEquals(gzipWithLevel,
BrokerCompressionType.GZIP.targetCompression(Optional.of(gzipWithLevel),
CompressionType.ZSTD));
Review Comment:
Fixed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
