showuon commented on code in PR #15516: URL: https://github.com/apache/kafka/pull/15516#discussion_r1607919763
########## storage/src/main/java/org/apache/kafka/storage/internals/log/LogValidator.java: ########## @@ -331,12 +332,12 @@ public ValidationResult assignOffsetsNonCompressed(LongRef offsetCounter, public ValidationResult validateMessagesAndAssignOffsetsCompressed(LongRef offsetCounter, MetricsRecorder metricsRecorder, BufferSupplier bufferSupplier) { - if (targetCompression == CompressionType.ZSTD && interBrokerProtocolVersion.isLessThan(IBP_2_1_IV0)) + if (targetCompression.type() == CompressionType.ZSTD && interBrokerProtocolVersion.isLessThan(IBP_2_1_IV0)) throw new UnsupportedCompressionTypeException("Produce requests to inter.broker.protocol.version < 2.1 broker " + "are not allowed to use ZStandard compression"); // No in place assignment situation 1 - boolean inPlaceAssignment = sourceCompression == targetCompression; + boolean inPlaceAssignment = sourceCompressionType == targetCompression.type(); Review Comment: I agree. But I think we should mention this in the KIP-390 at least. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org