lianetm commented on code in PR #15869: URL: https://github.com/apache/kafka/pull/15869#discussion_r1603351190
########## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ########## @@ -1968,9 +1972,13 @@ SubscriptionState subscriptions() { } private void maybeUpdateSubscriptionMetadata() { - if (subscriptions.hasPatternSubscription()) { - updatePatternSubscription(metadata.fetch()); + if (this.metadataVersionSnapshot < metadata.updateVersion()) { + this.metadataVersionSnapshot = metadata.updateVersion(); + if (subscriptions.hasPatternSubscription()) { + updatePatternSubscription(metadata.fetch()); + } } + updatePatternSubscription(metadata.fetch()); Review Comment: I would say this duplicated call ended up here by mistake? (and should be removed)...we only want to check/update the pattern if the metadata changed and `hasPatternSubscription` (done above on ln 1978) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org