lianetm commented on code in PR #15869: URL: https://github.com/apache/kafka/pull/15869#discussion_r1603594084
########## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ########## @@ -463,6 +467,42 @@ public void onPartitionsAssigned(final Collection<TopicPartition> partitions) { assertTrue(callbackExecuted.get()); } + @Test + public void testCheckForNewTopicOnlyWhenMetadataChange() { + SubscriptionState subscriptions = mock(SubscriptionState.class); + Cluster cluster = mock(Cluster.class); + + consumer = newConsumer( + mock(FetchBuffer.class), + mock(ConsumerInterceptors.class), + mock(ConsumerRebalanceListenerInvoker.class), + subscriptions, + singletonList(new RoundRobinAssignor()), + "group-id", + "client-id"); + + final String topicName = "foo"; + final int partition = 3; + final TopicPartition tp = new TopicPartition(topicName, partition); + doReturn(Fetch.empty()).when(fetchCollector).collectFetch(any(FetchBuffer.class)); + Map<TopicPartition, OffsetAndMetadata> offsets = mkMap(mkEntry(tp, new OffsetAndMetadata(1))); + completeFetchedCommittedOffsetApplicationEventSuccessfully(offsets); + doReturn(LeaderAndEpoch.noLeaderOrEpoch()).when(metadata).currentLeader(any()); + doReturn(cluster).when(metadata).fetch(); + + HashSet<String> topics = new HashSet<>(); + topics.add(topicName); + doReturn(topics).when(cluster).topics(); Review Comment: we could simplify this to a single `doReturn(Collections.singleton(topicName)).when(cluster).topics();` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org