chia7712 commented on code in PR #15976:
URL: https://github.com/apache/kafka/pull/15976#discussion_r1603390406
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##########
@@ -541,6 +541,28 @@ private void unload() {
}
}
+ class OperationTimeout extends TimerTask {
+ private final TopicPartition tp;
+ private final DeferredEvent event;
+
+ public OperationTimeout(
+ TopicPartition tp,
+ DeferredEvent event,
+ long delayMs
+ ) {
+ super(delayMs);
+ this.event = event;
+ this.tp = tp;
+ }
+
+ @Override
+ public void run() {
+ String name = event.toString();
+ scheduleInternalOperation("OperationTimeout", tp,
Review Comment:
previous operation name carries more information. Should we keep it? for
instance: `"OperationTimeout(name=" + name + ", tp=" + tp + ")"`
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##########
@@ -541,6 +541,28 @@ private void unload() {
}
}
+ class OperationTimeout extends TimerTask {
+ private final TopicPartition tp;
+ private final DeferredEvent event;
+
+ public OperationTimeout(
+ TopicPartition tp,
+ DeferredEvent event,
+ long delayMs
+ ) {
+ super(delayMs);
+ this.event = event;
+ this.tp = tp;
+ }
+
+ @Override
+ public void run() {
+ String name = event.toString();
Review Comment:
It does not include `if (!future.isDone()) {` now. Is it ok? I don't have
much context :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
