dajac commented on code in PR #15976: URL: https://github.com/apache/kafka/pull/15976#discussion_r1603394774
########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ########## @@ -541,6 +541,28 @@ private void unload() { } } + class OperationTimeout extends TimerTask { + private final TopicPartition tp; + private final DeferredEvent event; + + public OperationTimeout( + TopicPartition tp, + DeferredEvent event, + long delayMs + ) { + super(delayMs); + this.event = event; + this.tp = tp; + } + + @Override + public void run() { + String name = event.toString(); Review Comment: We don't need it anymore because we cancel the timer when the operation is completed. The future is completed at the same time so it is equivalent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org