nikramakrishnan commented on code in PR #15994:
URL: https://github.com/apache/kafka/pull/15994#discussion_r1606724750


##########
clients/src/main/java/org/apache/kafka/common/config/ConfigException.java:
##########
@@ -33,6 +33,10 @@ public ConfigException(String name, Object value) {
         this(name, value, null);
     }
 
+    public ConfigException(String message, Throwable cause) {
+        super(message, cause);

Review Comment:
   It might make sense to redirect the call to the other constructor 
`ConfigException(String name, Object value, String message)` with `name, null, 
null` here if `cause` is null, because we know that any caller passing a real 
`Throwable` won't pass a null.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to