gaurav-narula commented on PR #15994: URL: https://github.com/apache/kafka/pull/15994#issuecomment-2120832178
Thanks for the feedback @gharris1727. I dug a bit and it turns out the flakey test `DynamicBrokerReconfigurationTest::testTrustStoreAlter` that motivated this PR won't benefit from either cause or suppressed `Throwable`. This is because the test invokes `incrementalAlterConfigs` as a client and ConfigExceptions in the controller are converted to `ApiError` at https://github.com/apache/kafka/blob/81e609802187ac2bcbd0ac169fa10e8c02c237f5/metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java#L299 and we lose the cause/supressed throwable at that point (they aren't sent over the wire) :( I think the easiest change to debug the flakiness is to increase the logging level at https://github.com/apache/kafka/blob/81e609802187ac2bcbd0ac169fa10e8c02c237f5/clients/src/main/java/org/apache/kafka/common/security/ssl/SslFactory.java#L187 to `error` instead of `debug`. Alternatively, we may want to have that error log before https://github.com/apache/kafka/blob/81e609802187ac2bcbd0ac169fa10e8c02c237f5/metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java#L299 so that we ensure all reconfiguration errors are logged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
