OmniaGM commented on PR #15999: URL: https://github.com/apache/kafka/pull/15999#issuecomment-2123066293
> @OmniaGM I have left some comments in the discussion thread (https://lists.apache.org/thread/2scgvn66vs8c04ldxsj4sw2vlo6wd98o). It would be great if you have free time to take a look. > > For another code style idea: Could we have a new static class including all "emit"-related code? That will have following benefits. > > 1. more readable. The static class can be null (or empty) to "prove" that this function is "disabled" > 2. no unused objects are created. For example, `offsetProducer`, `delayedOffsetSyncs`, `pendingOffsetSyncs` are unused if the emit is disable > 3. easy to test emit behavior as all they in single static class now. > > WDYT? We kinda have `OffsetSyncStore` and based on the name it make it feel like the right place for this however, it is focused on read from the offsetSyncs topic. I added another one called `OffsetSyncWriter` and moved all emitting offsets code into there. let me know if this is okay! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
