OmniaGM commented on code in PR #15999:
URL: https://github.com/apache/kafka/pull/15999#discussion_r1609630391
##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java:
##########
@@ -109,9 +109,17 @@ public abstract class MirrorConnectorConfig extends
AbstractConfig {
public static final String TOPIC_FILTER_CLASS_DOC = "TopicFilter to use.
Selects topics to replicate.";
public static final Class<?> TOPIC_FILTER_CLASS_DEFAULT =
DefaultTopicFilter.class;
- public static final String OFFSET_SYNCS_TOPIC_LOCATION =
"offset-syncs.topic.location";
+ public static final String OFFSET_SYNCS_TOPIC_CONFIG_PREFIX =
"offset-syncs.topic.";
+ public static final String OFFSET_SYNCS_TOPIC_LOCATION =
OFFSET_SYNCS_TOPIC_CONFIG_PREFIX + "location";
public static final String OFFSET_SYNCS_TOPIC_LOCATION_DEFAULT =
SOURCE_CLUSTER_ALIAS_DEFAULT;
public static final String OFFSET_SYNCS_TOPIC_LOCATION_DOC = "The location
(source/target) of the offset-syncs topic.";
+
+ public static final String EMIT_OFFSET_SYNCS_ENABLED = "emit.offset-syncs"
+ MirrorCheckpointConfig.ENABLED_SUFFIX;
Review Comment:
`ENABLED_SUFFIX` actually part of MirrorConnectorConfig so I fixed this but
I used constants for `EMIT_OFFSET_SYNCS_ENABLED_DOC` for
`emit.checkpoints.enabled` and `sync.group.offsets.enabled`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
