TaiJuWu commented on code in PR #15862:
URL: https://github.com/apache/kafka/pull/15862#discussion_r1611087227


##########
core/src/test/java/kafka/test/junit/ClusterTestExtensionsUnitTest.java:
##########
@@ -33,16 +31,22 @@ public class ClusterTestExtensionsUnitTest {
     void testProcessClusterTemplate() {
         ClusterTestExtensions ext = new ClusterTestExtensions();
         ExtensionContext context = mock(ExtensionContext.class);
-        Consumer<TestTemplateInvocationContext> testInvocations = 
mock(Consumer.class);
         ClusterTemplate annot = mock(ClusterTemplate.class);
-        when(annot.value()).thenReturn("").thenReturn(" ");
+        when(annot.value()).thenReturn("").thenReturn(" 
").thenReturn("test_empty_config");

Review Comment:
   @soarez It seems not work because tester will test 
`@ClusterTemplate("cfgFoo")` and `@ClusterTemplate("")` and these method will 
make test fail.
   Please look at https://ge.apache.org/s/yyivyrph2oas6, thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to