apourchet commented on code in PR #16074:
URL: https://github.com/apache/kafka/pull/16074#discussion_r1613945311
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java:
##########
@@ -793,6 +811,14 @@ private boolean assignTasksToClients(final Cluster
fullMetadata,
return probingRebalanceNeeded;
}
+ private org.apache.kafka.streams.processor.assignment.TaskAssignor
createUserTaskAssignor(final boolean lagComputationSuccessful) {
+ if (!lagComputationSuccessful) {
+ log.info("Failed to fetch end offsets for changelogs, will return
previous assignment to clients and "
+ + "trigger another rebalance to retry.");
+ }
Review Comment:
Yeah I don't think this makes sense in a world where users have a clear
(read: non-internal) way to change assignment strategies and implementations.
So i removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
