ableegoldman commented on code in PR #16074:
URL: https://github.com/apache/kafka/pull/16074#discussion_r1613946928


##########
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##########
@@ -980,6 +983,11 @@ public class StreamsConfig extends AbstractConfig {
                     null,
                     Importance.MEDIUM,
                     RACK_AWARE_ASSIGNMENT_TRAFFIC_COST_DOC)
+            .define(TASK_ASSIGNOR_CLASS_CONFIG,
+                    Type.STRING,
+                    null,

Review Comment:
   I know it doesn't exist yet, but once we have the new HA assignor then imo 
we should use that as the default here. Then the logic will be as such:
   1. If the new config is set but not the old one, use the new config assignor
   2. If the old config is set but not the new one, use the old config assignor
   3. If both configs are set, use the new config assignor
   4. If neither config is set, use the new config assignor (ie default to new 
HA assignor)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to