kirktrue commented on code in PR #16031:
URL: https://github.com/apache/kafka/pull/16031#discussion_r1618006437
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -767,53 +771,30 @@ CompletableFuture<?> future() {
void resetFuture() {
future = new CompletableFuture<>();
}
-
- @Override
- void removeRequest() {
- if (!unsentOffsetCommitRequests().remove(this)) {
- log.warn("OffsetCommit request to remove not found in the
outbound buffer: {}", this);
- }
- }
Review Comment:
This is not needed because we don't prune unsent-but-expired requests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
