kirktrue commented on code in PR #16031:
URL: https://github.com/apache/kafka/pull/16031#discussion_r1618006717
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -767,53 +771,30 @@ CompletableFuture<?> future() {
void resetFuture() {
future = new CompletableFuture<>();
}
-
- @Override
- void removeRequest() {
- if (!unsentOffsetCommitRequests().remove(this)) {
- log.warn("OffsetCommit request to remove not found in the
outbound buffer: {}", this);
- }
- }
}
/**
* Represents a request that can be retried or aborted, based on member ID
and epoch
* information.
*/
- abstract class RetriableRequestState extends RequestState {
+ abstract class RetriableRequestState extends TimedRequestState {
/**
* Member info (ID and epoch) to be included in the request if present.
*/
final MemberInfo memberInfo;
- /**
- * Time until which the request should be retried if it fails with
retriable
- * errors. If not present, the request is triggered without waiting
for a response or
- * retrying.
- */
- private final Optional<Long> expirationTimeMs;
-
- /**
- * True if the request expiration time has been reached. This is set
when validating the
- * request expiration on {@link #poll(long)} before sending it. It is
used to know if a
- * request should be retried on TimeoutException.
- */
- boolean isExpired;
-
Review Comment:
This is rolled into `TimedRequestState`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
