chia7712 commented on code in PR #16110:
URL: https://github.com/apache/kafka/pull/16110#discussion_r1618766155
##########
core/src/test/java/kafka/test/ClusterConfigTest.java:
##########
@@ -96,4 +99,16 @@ public void testDisksPerBrokerIsZero() {
.setDisksPerBroker(0)
.build());
}
+
+ @Test
+ public void testDisplayTags() {
+ List<String> tags = Collections.singletonList("example tag");
+ ClusterConfig clusterConfig =
ClusterConfig.defaultBuilder().setTags(tags).build();
+
+ Set<String> expectedDisplayTags = new LinkedHashSet<>(tags);
Review Comment:
This testing code is almost same with production code. Maybe we don't need
to verify the "format" of display tags. Instead, we check the output which
should "contain" expected strings. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
