cmccabe commented on code in PR #15986:
URL: https://github.com/apache/kafka/pull/15986#discussion_r1619511561
##########
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##########
@@ -1635,24 +1693,29 @@ private Optional<Boolean> maybeHandleCommonResponse(
}
private void maybeTransition(
- OptionalInt leaderId,
+ Optional<Node> leader,
int epoch,
long currentTimeMs
) {
+ OptionalInt leaderId = OptionalInt.empty();
Review Comment:
Again would be more clearly expressed with `?:` rather than mutating the
OptionalInt reference
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
