chia7712 commented on code in PR #16097:
URL: https://github.com/apache/kafka/pull/16097#discussion_r1621358471
##########
checkstyle/suppressions.xml:
##########
@@ -361,4 +361,7 @@
<suppress checks="(ClassDataAbstractionCoupling|ClassFanOutComplexity)"
files="(ReplicaFetcherThreadBenchmark).java"/>
+ <!--import order -->
+ <suppress checks="ImportOrder" files="^*$"/>
Review Comment:
why we need this change?
##########
build.gradle:
##########
@@ -1007,7 +1026,7 @@ project(':core') {
testImplementation libs.junitJupiter
testImplementation libs.slf4jlog4j
testImplementation libs.caffeine
-
Review Comment:
please revert this change
##########
build.gradle:
##########
@@ -47,7 +47,7 @@ plugins {
// Updating the shadow plugin version to 8.1.1 causes issue with signing and
publishing the shadowed
// artifacts - see https://github.com/johnrengelman/shadow/issues/901
id 'com.github.johnrengelman.shadow' version '8.1.0' apply false
- id 'com.diffplug.spotless' version '6.14.0' apply false // 6.14.1 and newer
require Java 11 at compile time, so we can't upgrade until AK 4.0
+ id 'com.diffplug.spotless' version "${spotlessVersion}" apply false
Review Comment:
Do we need this variable? Also, why not using latest version `6.25.0`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
