chia7712 commented on code in PR #16097:
URL: https://github.com/apache/kafka/pull/16097#discussion_r1623249229
##########
checkstyle/checkstyle.xml:
##########
@@ -82,6 +82,10 @@
<property name="file" value="${config_loc}/${importControlFile}"/>
</module>
+ <!-- import order rule not config in the checkstyle.xml.
Review Comment:
how about:
```
DON'T define any import order here! Import order check/format is addressed
by spotless.
```
##########
build.gradle:
##########
@@ -47,7 +47,8 @@ plugins {
// Updating the shadow plugin version to 8.1.1 causes issue with signing and
publishing the shadowed
// artifacts - see https://github.com/johnrengelman/shadow/issues/901
id 'com.github.johnrengelman.shadow' version '8.1.0' apply false
- id 'com.diffplug.spotless' version '6.14.0' apply false // 6.14.1 and newer
require Java 11 at compile time, so we can't upgrade until AK 4.0
+ // 6.14.0 and newer are need for java 11
Review Comment:
how about: `the minimum required JRE of 6.14.0+ is 11`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
