TaiJuWu commented on code in PR #16156:
URL: https://github.com/apache/kafka/pull/16156#discussion_r1622573645
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##########
@@ -298,7 +298,7 @@ private void sendUnsentRequests(final Timer timer) {
do {
Review Comment:
Do we need the early return?
If there is a request in in-flight but unSentRequestQueue is empty, we will
lose the newest request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
